streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STREAMS-176) TwitterTimelineProvider and Task should allow for overriding certain methods
Date Tue, 07 Oct 2014 14:21:33 GMT

    [ https://issues.apache.org/jira/browse/STREAMS-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14161923#comment-14161923
] 

ASF GitHub Bot commented on STREAMS-176:
----------------------------------------

Github user mfranklin commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/86#discussion_r18521763
  
    --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java
---
    @@ -116,11 +115,11 @@ public void startStream() {
             executor.shutdown();
         }
     
    -    protected boolean shouldContinuePulling(List<Status> statuses) {
    +    public boolean shouldContinuePulling(List<Status> statuses) {
    --- End diff --
    
    @robdouglas Any reason?


> TwitterTimelineProvider and Task should allow for overriding certain methods
> ----------------------------------------------------------------------------
>
>                 Key: STREAMS-176
>                 URL: https://issues.apache.org/jira/browse/STREAMS-176
>             Project: Streams
>          Issue Type: Task
>            Reporter: Robert Douglas
>
> There are certain methods where it could be beneficial for a downstream developer to
override. Functions like submitTimelineThreads, getTwitterClient, and addDatum could foreseeably
be overridden



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message