streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rbnks <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: STREAMS-199 | Implemented new coun...
Date Fri, 31 Oct 2014 14:57:24 GMT
Github user rbnks commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/109#discussion_r19671069
  
    --- Diff: streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StreamsPersistWriterTask.java
---
    @@ -111,14 +113,18 @@ public void run() {
                         Thread.currentThread().interrupt();
                     }
                     if(datum != null) {
    +                    this.counter.incrementReceivedCount();
                         try {
    +                        long startTime = System.currentTimeMillis();
                             this.writer.write(datum);
    +                        this.counter.addTime(System.currentTimeMillis() - startTime);
                             statusCounter.incrementStatus(DatumStatus.SUCCESS);
                         } catch (Exception e) {
                             LOGGER.error("Error writing to persist writer {}", this.writer.getClass().getSimpleName(),
e);
                             this.keepRunning.set(false); // why do we shutdown on a failed
write ?
    --- End diff --
    
    This out of the scope of this pull request, and is not a change made by this pull request.
but we can open a ticket to make this change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message