streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rbnks <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Streams 191
Date Mon, 13 Oct 2014 20:51:35 GMT
Github user rbnks commented on the pull request:

    https://github.com/apache/incubator-streams/pull/100#issuecomment-58952963
  
    @steveblackmon 
    So, previously the queue was able to be replaced because we were unsure of what the best
implementation to use and we left it wide open and required the Queue interface.  Now it requires
a blocking Queue interface.
    
    We could open it back up to allow any BlockingQueue implementation to be put in there.
 However, I do think this is a good idea or necessary.  The user shouldn't have a need to
define the message passage from each StreamsOperation.  I believe the user should only have
the option to decide how many datums are allowed to be on each queue.  This allows to make
changes, swap the queue for other message passing systems without introducing breaking changes
in the future.  
    
    This is a breaking change.  Which does need to be communicated through the email list
serve before this gets merged in (good catch on that).  However, I think it is a needed breaking
change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message