streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From steveblackmon <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: added scrollTimeout to Elasticsear...
Date Wed, 08 Oct 2014 20:38:15 GMT
Github user steveblackmon commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/97#discussion_r18610515
  
    --- Diff: streams-contrib/streams-persist-elasticsearch/src/main/java/org/apache/streams/elasticsearch/ElasticsearchQuery.java
---
    @@ -128,8 +122,8 @@ public void execute(Object o) {
                         .setExplain(true)
                         .addField("*")
                         .setFetchSource(true)
    -                    .setSize(Objects.firstNonNull(batchSize, DEFAULT_BATCH_SIZE).intValue())
    --- End diff --
    
    It can't be.  It has a default value in the generated configuration object.
    
    Steve Blackmon
    
    > On Oct 8, 2014, at 1:14 PM, Robert Douglas <notifications@github.com> wrote:
    > 
    > In streams-contrib/streams-persist-elasticsearch/src/main/java/org/apache/streams/elasticsearch/ElasticsearchQuery.java:
    > 
    > > @@ -128,8 +122,8 @@ public void execute(Object o) {
    > >                      .setExplain(true)
    > >                      .addField("*")
    > >                      .setFetchSource(true)
    > > -                    .setSize(Objects.firstNonNull(batchSize, DEFAULT_BATCH_SIZE).intValue())
    > What happens if batchSize is null?
    > 
    > —
    > Reply to this email directly or view it on GitHub.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message