streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From renato2099 <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Made linesPerFile configurable
Date Tue, 07 Oct 2014 14:53:39 GMT
Github user renato2099 commented on the pull request:

    https://github.com/apache/incubator-streams/pull/82#issuecomment-58197188
  
    Hi Steve,
    
    Why don't creating separate issue per module that uses this new configuration scheme?
And let PR#82 be with the one associated with updating HDFS? And it would make sense that
the tests only go in the centralized configuration manager class. I am :+1: to merge this
if it is done that way.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message