Return-Path: 
 <dev-return-1832-apmail-streams-dev-archive=streams.apache.org@streams.incubator.apache.org>
X-Original-To: apmail-streams-dev-archive@minotaur.apache.org
Delivered-To: apmail-streams-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 8945411F5E
	for <apmail-streams-dev-archive@minotaur.apache.org>;
 Wed, 24 Sep 2014 17:55:55 +0000 (UTC)
Received: (qmail 7711 invoked by uid 500); 24 Sep 2014 17:55:55 -0000
Delivered-To: apmail-streams-dev-archive@streams.apache.org
Received: (qmail 7668 invoked by uid 500); 24 Sep 2014 17:55:55 -0000
Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@streams.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@streams.incubator.apache.org>
List-Post: <mailto:dev@streams.incubator.apache.org>
List-Id: <dev.streams.incubator.apache.org>
Reply-To: dev@streams.incubator.apache.org
Delivered-To: mailing list dev@streams.incubator.apache.org
Received: (qmail 7657 invoked by uid 99); 24 Sep 2014 17:55:55 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Sep 2014 17:55:55 +0000
X-ASF-Spam-Status: No, hits=-2000.8 required=5.0
	tests=ALL_TRUSTED,RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3)
    by apache.org (qpsmtpd/0.29) with SMTP; Wed, 24 Sep 2014 17:55:54 +0000
Received: (qmail 7274 invoked by uid 99); 24 Sep 2014 17:55:33 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Sep 2014 17:55:33 +0000
Date: Wed, 24 Sep 2014 17:55:33 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@streams.incubator.apache.org
Message-ID: <JIRA.12741883.1410893245000.113914.1411581333862@Atlassian.JIRA>
In-Reply-To: <JIRA.12741883.1410893245000@Atlassian.JIRA>
References: <JIRA.12741883.1410893245000@Atlassian.JIRA>
 <JIRA.12741883.1410893245103@arcas>
Subject: [jira] [Commented] (STREAMS-176) TwitterTimelineProvider and Task
 should allow for overriding certain methods
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/STREAMS-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146609#comment-14146609 ] 

ASF GitHub Bot commented on STREAMS-176:
----------------------------------------

Github user mfranklin commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/86#discussion_r17988007
  
    --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java ---
    @@ -116,11 +115,11 @@ public void startStream() {
             executor.shutdown();
         }
     
    -    protected boolean shouldContinuePulling(List<Status> statuses) {
    +    public boolean shouldContinuePulling(List<Status> statuses) {
    --- End diff --
    
    Why mark this public, it was already protected?


> TwitterTimelineProvider and Task should allow for overriding certain methods
> ----------------------------------------------------------------------------
>
>                 Key: STREAMS-176
>                 URL: https://issues.apache.org/jira/browse/STREAMS-176
>             Project: Streams
>          Issue Type: Task
>            Reporter: Robert Douglas
>
> There are certain methods where it could be beneficial for a downstream developer to override. Functions like submitTimelineThreads, getTwitterClient, and addDatum could foreseeably be overridden



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)