Return-Path: X-Original-To: apmail-streams-dev-archive@minotaur.apache.org Delivered-To: apmail-streams-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EF07511F29 for ; Mon, 22 Sep 2014 15:12:57 +0000 (UTC) Received: (qmail 16077 invoked by uid 500); 22 Sep 2014 15:12:57 -0000 Delivered-To: apmail-streams-dev-archive@streams.apache.org Received: (qmail 16032 invoked by uid 500); 22 Sep 2014 15:12:57 -0000 Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@streams.incubator.apache.org Delivered-To: mailing list dev@streams.incubator.apache.org Received: (qmail 16021 invoked by uid 99); 22 Sep 2014 15:12:57 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Sep 2014 15:12:57 +0000 X-ASF-Spam-Status: No, hits=-2000.8 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 22 Sep 2014 15:12:36 +0000 Received: (qmail 15226 invoked by uid 99); 22 Sep 2014 15:12:33 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Sep 2014 15:12:33 +0000 Date: Mon, 22 Sep 2014 15:12:33 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@streams.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (STREAMS-166) S3PersistReader does not correctly handle directory listing MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/STREAMS-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143291#comment-14143291 ] ASF GitHub Bot commented on STREAMS-166: ---------------------------------------- Github user renato2099 commented on the pull request: https://github.com/apache/incubator-streams/pull/80#issuecomment-56387888 Yeah you are right, it turns out to be the same $$$ [1], and this reader doesn't have too many configuration parameters ;) [2] but this is just my 2c. I think the changes are cool besides that :+1: [1] http://aws.amazon.com/s3/pricing/ [2]https://github.com/apache/incubator-streams/blob/master/streams-contrib/streams-amazon-aws/streams-persist-s3/src/main/jsonschema/org/apache/streams/s3/S3ReaderConfiguration.json > S3PersistReader does not correctly handle directory listing > ----------------------------------------------------------- > > Key: STREAMS-166 > URL: https://issues.apache.org/jira/browse/STREAMS-166 > Project: Streams > Issue Type: Bug > Reporter: Robert Douglas > Original Estimate: 3h > Remaining Estimate: 3h > > In its current form, the S3PeristReader is not able to pick up on files inside of a given directory. In addition to checking for common prefixes, we need to ensure there are no object summaries in the listing response before we assume we are dealing with a single file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)