Return-Path: X-Original-To: apmail-streams-dev-archive@minotaur.apache.org Delivered-To: apmail-streams-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 73C3111943 for ; Wed, 10 Sep 2014 09:54:50 +0000 (UTC) Received: (qmail 98462 invoked by uid 500); 10 Sep 2014 09:54:50 -0000 Delivered-To: apmail-streams-dev-archive@streams.apache.org Received: (qmail 98420 invoked by uid 500); 10 Sep 2014 09:54:50 -0000 Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@streams.incubator.apache.org Delivered-To: mailing list dev@streams.incubator.apache.org Received: (qmail 98409 invoked by uid 99); 10 Sep 2014 09:54:50 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Sep 2014 09:54:50 +0000 X-ASF-Spam-Status: No, hits=-2001.7 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 10 Sep 2014 09:54:49 +0000 Received: (qmail 97713 invoked by uid 99); 10 Sep 2014 09:54:29 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Sep 2014 09:54:29 +0000 Date: Wed, 10 Sep 2014 09:54:29 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@streams.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (STREAMS-166) S3PersistReader does not correctly handle directory listing MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/STREAMS-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128291#comment-14128291 ] ASF GitHub Bot commented on STREAMS-166: ---------------------------------------- Github user renato2099 commented on the pull request: https://github.com/apache/incubator-streams/pull/80#issuecomment-55094096 Hi Robert, This looks great, but wouldn't it be better if you put the 500 value used for configuring the S3 reader as a constant? And maybe adding a simple test for this feature? I mean reading from a directory or from a single object, or at least opening a JIRA issue for it. > S3PersistReader does not correctly handle directory listing > ----------------------------------------------------------- > > Key: STREAMS-166 > URL: https://issues.apache.org/jira/browse/STREAMS-166 > Project: Streams > Issue Type: Bug > Reporter: Robert Douglas > Original Estimate: 3h > Remaining Estimate: 3h > > In its current form, the S3PeristReader is not able to pick up on files inside of a given directory. In addition to checking for common prefixes, we need to ensure there are no object summaries in the listing response before we assume we are dealing with a single file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)