streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STREAMS-166) S3PersistReader does not correctly handle directory listing
Date Wed, 10 Sep 2014 09:54:29 GMT

    [ https://issues.apache.org/jira/browse/STREAMS-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128291#comment-14128291
] 

ASF GitHub Bot commented on STREAMS-166:
----------------------------------------

Github user renato2099 commented on the pull request:

    https://github.com/apache/incubator-streams/pull/80#issuecomment-55094096
  
    Hi Robert,
    
    This looks great, but wouldn't it be better if you put the 500 value used for configuring
the S3 reader as a constant? And maybe adding a simple test for this feature? I mean reading
from a directory or from a single object, or at least opening a JIRA issue for it. 



> S3PersistReader does not correctly handle directory listing
> -----------------------------------------------------------
>
>                 Key: STREAMS-166
>                 URL: https://issues.apache.org/jira/browse/STREAMS-166
>             Project: Streams
>          Issue Type: Bug
>            Reporter: Robert Douglas
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> In its current form, the S3PeristReader is not able to pick up on files inside of a given
directory. In addition to checking for common prefixes, we need to ensure there are no object
summaries in the listing response before we assume we are dealing with a single file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message