streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mfranklin <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: STREAMS-176 | Added ability to ove...
Date Wed, 24 Sep 2014 17:54:38 GMT
Github user mfranklin commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/86#discussion_r17988007
  
    --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java
---
    @@ -116,11 +115,11 @@ public void startStream() {
             executor.shutdown();
         }
     
    -    protected boolean shouldContinuePulling(List<Status> statuses) {
    +    public boolean shouldContinuePulling(List<Status> statuses) {
    --- End diff --
    
    Why mark this public, it was already protected?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message