streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From steveblackmon <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Made linesPerFile configurable
Date Wed, 24 Sep 2014 16:33:00 GMT
Github user steveblackmon commented on the pull request:

    https://github.com/apache/incubator-streams/pull/82#issuecomment-56698078
  
    I don't believe it's necessary to test every individual configurator - they should all
be doing exactly the same thing - using TypeSafe concise rendering and Jackson to initialize
a bean from a fragment of the combined json/hocon/property-file global typesafe config.
    
    I would support adding a class to streams-config to handle this on behalf of all the module
so there would just be one central place to tweak config parsing behavior in the future and
adding some tests there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message