streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sieverssj <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: STREAMS-178 | Modified the behavio...
Date Thu, 18 Sep 2014 15:52:12 GMT
Github user sieverssj commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/90#discussion_r17735841
  
    --- Diff: streams-contrib/streams-processor-urls/src/test/java/org/apache/streams/urls/TestLinkUnwinderProcessor.java
---
    @@ -76,8 +76,8 @@ public void testActivityLinkUnwinderProcessorGoDaddy() throws Exception{
     
         @Test
         public void testActivityLinkUnwinderProcessorMulti() throws Exception{
    -        testActivityUnwinderHelper(Lists.newArrayList("http://x.co/3yapt", "http://ow.ly/u4Kte",
"http://goo.gl/wSrHDA"), Lists.newArrayList("http://www.wcgworld.com/", "http://www.wcgworld.com/",
"http://www.wcgworld.com/"));
    -        testStringActivityUnwinderHelper(Lists.newArrayList("http://x.co/3yapt", "http://ow.ly/u4Kte",
"http://goo.gl/wSrHDA"), Lists.newArrayList("http://www.wcgworld.com/", "http://www.wcgworld.com/",
"http://www.wcgworld.com/"));
    +        testActivityUnwinderHelper(Lists.newArrayList("http://x.co/3yapt", "http://ow.ly/u4Kte",
"http://goo.gl/wSrHDA"), Lists.newArrayList("http://www.wcgworld.com/"));//, "http://www.wcgworld.com/",
"http://www.wcgworld.com/"));
    --- End diff --
    
    Small nit: Get rid of the commented out code on the end of these lines.
    
    Assuming that happens, :+1:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message