streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From renato2099 <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: STREAMS-166 | Modified the S3Peris...
Date Wed, 10 Sep 2014 09:54:15 GMT
Github user renato2099 commented on the pull request:

    https://github.com/apache/incubator-streams/pull/80#issuecomment-55094096
  
    Hi Robert,
    
    This looks great, but wouldn't it be better if you put the 500 value used for configuring
the S3 reader as a constant? And maybe adding a simple test for this feature? I mean reading
from a directory or from a single object, or at least opening a JIRA issue for it. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message