streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STREAMS-152) Add a flag that forces use of Elasticsearch Configuration
Date Thu, 21 Aug 2014 00:11:27 GMT

    [ https://issues.apache.org/jira/browse/STREAMS-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104832#comment-14104832
] 

ASF GitHub Bot commented on STREAMS-152:
----------------------------------------

Github user mfranklin commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/71#discussion_r16514241
  
    --- Diff: streams-contrib/streams-persist-elasticsearch/src/main/java/org/apache/streams/elasticsearch/ElasticsearchPersistWriter.java
---
    @@ -146,14 +146,18 @@ public void write(StreamsDatum streamsDatum) {
     
             String index = Optional.fromNullable(
    --- End diff --
    
    I would write this as 
    
    ````
    String index = streamsDatum.getMetadata().get("index");
    if(index == null || config.getForceUseConfig()) {
        index = config.getIndex();
    }
    ````


> Add a flag that forces use of Elasticsearch Configuration
> ---------------------------------------------------------
>
>                 Key: STREAMS-152
>                 URL: https://issues.apache.org/jira/browse/STREAMS-152
>             Project: Streams
>          Issue Type: Task
>            Reporter: Robert Douglas
>
> Add a flag that forces use of Elasticsearch Configuration



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message