streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STREAMS-139) buildProvider in SyndEntryActivitySerializer can incorrectly set the URL
Date Tue, 05 Aug 2014 21:33:14 GMT

    [ https://issues.apache.org/jira/browse/STREAMS-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086814#comment-14086814
] 

ASF GitHub Bot commented on STREAMS-139:
----------------------------------------

GitHub user robdouglas opened a pull request:

    https://github.com/apache/incubator-streams/pull/64

    Streams 139

    STREAMS-139 | Updated the buildProvider method in the SyndEntry Serializer to ensure that
we use a valid URI for the link attribute

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robdouglas/incubator-streams STREAMS-139

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-streams/pull/64.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #64
    
----
commit a22a99c4d56de09d96714070d77448dad4a6bde6
Author: Robert Douglas <rdouglas@w2odigital.com>
Date:   2014-08-05T20:01:59Z

    Merge pull request #9 from apache/master
    
    Merge Apache

commit 9e72ae74154eb942d3e12ab183cc25540a7bfbcc
Author: Robert Douglas <rdouglas@w2odigital.com>
Date:   2014-08-05T21:29:40Z

    STREAMS-139 | Updated the buildProvider method in the SyndEntry Serializer to ensure that
we use a valid URI for the link attribute

----


> buildProvider in SyndEntryActivitySerializer can incorrectly set the URL
> ------------------------------------------------------------------------
>
>                 Key: STREAMS-139
>                 URL: https://issues.apache.org/jira/browse/STREAMS-139
>             Project: Streams
>          Issue Type: Bug
>            Reporter: Robert Douglas
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> At the moment, the buildProvider only checks to see if a URI contains 'www' or 'http;',
when it should really be checking to see if the URI starts with either of those tokens. Otherwise,
we can get into a situation where the URL will get set to something like '291886 at http://www.whitehouse.gov'
which is not a valid URL.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message