streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rbnks <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: STREAMS-152 | Added flag that allo...
Date Thu, 21 Aug 2014 16:25:08 GMT
Github user rbnks commented on the pull request:

    https://github.com/apache/incubator-streams/pull/71#issuecomment-52944878
  
    :+1:  This looks good.  Although this code is getting messy.  I think we probably want
to look to refactoring this code out and creating mapping objects that will allow user to
implement how the index/type/id are set.  We can create a default one that works the same
as it currently does, but allow users to override it with custom ones.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message