streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robdouglas <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Streams 115
Date Thu, 07 Aug 2014 18:30:26 GMT
Github user robdouglas commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/51#discussion_r15954260
  
    --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProviderTask.java
---
    @@ -58,47 +56,39 @@ public void run() {
                 int keepTrying = 0;
     
                 // keep trying to load, give it 5 attempts.
    -            //while (keepTrying < 10)
    -            while (keepTrying < 1)
    +            //This value was chosen because it seemed like a reasonable number of times
    +            //to retry capturing a timeline given the sorts of errors that could potentially
    +            //occur (network timeout/interruption, faulty client, etc.)
    +            while (keepTrying < 5)
                 {
     
                     try
                     {
    -                    statuses = twitter.getUserTimeline(id, paging);
    +                    statuses = client.getUserTimeline(id, paging);
    --- End diff --
    
    Before this step, it may make sense to fetch a new twitter client


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message