streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robdouglas <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Streams 115
Date Thu, 07 Aug 2014 16:01:41 GMT
Github user robdouglas commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/51#discussion_r15944963
  
    --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java
---
    @@ -325,4 +274,49 @@ protected Twitter getTwitterClient()
         public void cleanUp() {
             shutdownAndAwaitTermination(executor);
         }
    +
    +    protected List<Long> numericIdsOnly(List<String> allIds) {
    +        List<Long> result = Lists.newArrayList();
    +        for(String id : allIds) {
    +            if(id != null)
    +            {
    +                // See if it is a long, if it is, add it to the user iD list, if it is
not, add it to the
    +                // screen name list
    +                try {
    +                    result.add(Long.parseLong(id));
    +                } catch (NumberFormatException e) {}
    --- End diff --
    
    The comment above states that if an id is NOT a long then ti should be added to the screen
name list. Is there a reason why this is not happening in the catch block?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message