streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From steveblackmon <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: updater implementation
Date Thu, 07 Aug 2014 15:43:41 GMT
Github user steveblackmon commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/63#discussion_r15943674
  
    --- Diff: streams-contrib/streams-persist-elasticsearch/src/main/java/org/apache/streams/elasticsearch/ElasticsearchPersistWriter.java
---
    @@ -142,8 +143,16 @@ public void write(StreamsDatum streamsDatum) {
     
             checkForBackOff();
     
    +        String index = Optional.fromNullable(
    --- End diff --
    
    There are three ( four the case of updater ) strings that are pulled from metadata but
defaulted to writer configuration.  Should the method return a Triple?  These are already
single-line assignments formatted for readability - I don't see any how abstraction makes
code simpler or more readable here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message