streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mfranklin <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Streams 139
Date Wed, 06 Aug 2014 13:27:15 GMT
Github user mfranklin commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/64#discussion_r15872705
  
    --- Diff: streams-contrib/streams-provider-rss/src/main/java/org/apache/streams/rss/serializer/SyndEntryActivitySerializer.java
---
    @@ -179,7 +179,7 @@ private Provider buildProvider(ObjectNode entry) {
                 uri = entry.get("uri").textValue();
     
             if (uri != null) {
    -            if((uri.contains("http") || uri.contains("www")) || (link == null || !(link.contains("http")
|| link.contains("www")))) {
    +            if((uri.startsWith("http") || uri.startsWith("www")) || (link == null ||
!(link.startsWith("http") || link.startsWith("www")))) {
    --- End diff --
    
    Add some comments around this logic.  As it is written it looks like:
    
    "Check that the URI is valid (starts with http or www) if not and the link is also invalid,
then go ahead and use the URI anyway" 
    
    Why would that be the desired behavior?  How is that functionally different than "If the
link is invalid, use the URI"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message