streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mfranklin <>
Subject [GitHub] incubator-streams pull request: updater implementation
Date Wed, 06 Aug 2014 13:22:52 GMT
Github user mfranklin commented on a diff in the pull request:
    --- Diff: streams-contrib/streams-persist-elasticsearch/src/main/java/org/apache/streams/elasticsearch/
    @@ -142,8 +143,16 @@ public void write(StreamsDatum streamsDatum) {
    +        String index = Optional.fromNullable(
    --- End diff --
    pull this into a protected method(s) rather than triplicate the logic

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message