streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mfranklin <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Streams 115
Date Mon, 21 Jul 2014 14:08:01 GMT
Github user mfranklin commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/51#discussion_r15170031
  
    --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java
---
    @@ -272,11 +244,10 @@ void shutdownAndAwaitTermination(ExecutorService pool) {
             }
         }
     
    -
         @Override
         public void prepare(Object o) {
     
    -        executor = MoreExecutors.listeningDecorator(newFixedThreadPoolWithQueueSize(5,
20));
    +        executor = getExecutor();
             running.set(true);
    --- End diff --
    
    Wouldn't you start running on startStream?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message