streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mfranklin <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Streams 131
Date Mon, 14 Jul 2014 19:38:59 GMT
Github user mfranklin commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/52#discussion_r14898698
  
    --- Diff: streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StreamsProcessorTask.java
---
    @@ -105,8 +105,8 @@ public void run() {
                 }
     
             } finally {
    -            this.processor.cleanUp();
                 this.isRunning.set(false);
    +            this.processor.cleanUp();
    --- End diff --
    
    it was moved because the isRunning flag is used (in part) to determine whether or not
to continue polling the provider for data.  we should stop polling the provider for data before
cleaning.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message