streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rbnks <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Streams 115
Date Mon, 14 Jul 2014 19:35:47 GMT
Github user rbnks commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/51#discussion_r14898532
  
    --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterErrorHandler.java
---
    @@ -42,7 +42,7 @@ public static int handleTwitterError(Twitter twitter, Exception exception)
                 {
                     LOGGER.warn("Rate Limit Exceeded");
                     try {
    -                    Thread.sleep(backoff *= 2);
    +                    Thread.sleep(retry);
                     } catch (InterruptedException e1) {}
    --- End diff --
    
    I know this isn't party of your pull request, but we shouldn't be swallowing InterruptedExceptions.
 Can we fix this or at least open a ticket to fix it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message