streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rbnks <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Streams 131
Date Mon, 14 Jul 2014 19:31:42 GMT
Github user rbnks commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/52#discussion_r14898303
  
    --- Diff: streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StreamsProcessorTask.java
---
    @@ -105,8 +105,8 @@ public void run() {
                 }
     
             } finally {
    -            this.processor.cleanUp();
                 this.isRunning.set(false);
    +            this.processor.cleanUp();
    --- End diff --
    
    Why is cleanUp() moved to after isRunning.set(false)?  I believe you are creating a race
condition here.  The ProcesssorTask should still be running while its cleaning up.  That way
the task cannot be put up for garbage collection while its cleaning up.  In cleaning up, it
could be emptying internal queues or closing connections.  All things we want to guarantee
happen.  Has the implementation changed so that this i not the case?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message