streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mfranklin <>
Subject [GitHub] incubator-streams pull request: Streams 121
Date Mon, 14 Jul 2014 15:31:45 GMT
Github user mfranklin commented on a diff in the pull request:
    --- Diff: streams-contrib/streams-provider-instagram/src/main/java/org/apache/streams/instagram/provider/
    @@ -0,0 +1,101 @@
    +package org.apache.streams.instagram.provider;
    +import org.apache.streams.config.StreamsConfigurator;
    +import org.apache.streams.core.StreamsDatum;
    +import org.apache.streams.core.StreamsProvider;
    +import org.apache.streams.core.StreamsResultSet;
    +import org.apache.streams.instagram.InstagramConfigurator;
    +import org.apache.streams.instagram.InstagramUserInformationConfiguration;
    +import org.jinstagram.entity.users.feed.MediaFeedData;
    +import org.joda.time.DateTime;
    +import java.math.BigInteger;
    +import java.util.Queue;
    +import java.util.concurrent.ExecutorService;
    +import java.util.concurrent.Executors;
    +import java.util.concurrent.TimeUnit;
    + * Instagram {@link org.apache.streams.core.StreamsProvider} that provides the recent
media data for a group of users
    + */
    +public class InstagramRecentMediaProvider implements StreamsProvider {
    +    private InstagramUserInformationConfiguration config;
    +    private InstagramRecentMediaCollector dataCollector;
    +    protected Queue<MediaFeedData> mediaFeedQueue; //exposed for testing
    +    private ExecutorService executorService;
    +    private volatile boolean isCompleted;
    --- End diff --
    True that it isn't required in this context, and that a non-thread-local cached value
will be fine, but the Atomic pattern is widely used throughout the codebase and the minor
locking in Atomic will have no performance implication 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message