streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rbnks <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Streams 127
Date Tue, 08 Jul 2014 20:25:20 GMT
Github user rbnks commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/50#discussion_r14678081
  
    --- Diff: streams-contrib/streams-provider-datasift/src/main/java/org/apache/streams/datasift/serializer/DatasiftTweetActivitySerializer.java
---
    @@ -129,51 +129,6 @@ public Actor buildActor(Datasift event, Twitter twitter) {
             return actor;
         }
     
    -    //Need to make retweet user and tweet user the same object.
    --- End diff --
    
    No, they were the same object/same repeated json schema.  But since it was repeated, it
was labeled as different java objects so there were two different java types for the same
functionality.  No the user object json schema has been defined in its own file, and that
is referenced by the datasift jsonschema.  So its the same functionality, but now through
a signle object.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message