streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mfranklin <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Streams 105
Date Wed, 02 Jul 2014 13:13:47 GMT
Github user mfranklin commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/47#discussion_r14455605
  
    --- Diff: streams-contrib/streams-provider-datasift/src/main/java/org/apache/streams/datasift/serializer/DatasiftTweetActivitySerializer.java
---
    @@ -167,13 +143,22 @@ public Actor retweetBuildActor(Actor actor, org.apache.streams.datasift.twitter.
             if(actor.getImage() == null && profileUrl == null) {
                 profileUrl = user.getProfileImageUrl();
             }
    -        profileImage.setUrl(profileUrl);
    -        actor.setImage(profileImage);
    +
    +        if(profileUrl != null) {
    +            profileImage.setUrl(profileUrl);
    +            actor.setImage(profileImage);
    +        }
     
             actor.setAdditionalProperty("extensions", extensions);
             return actor;
         }
     
    +    /**
    +     * Adds location attributes from the given Twitter object
    +     *
    +     * @param activity
    +     * @param twitter
    +     */
    --- End diff --
    
    The coordinates should be geojson values, in this case, the type would be Point


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message