Return-Path: 
 <dev-return-1248-apmail-streams-dev-archive=streams.apache.org@streams.incubator.apache.org>
X-Original-To: apmail-streams-dev-archive@minotaur.apache.org
Delivered-To: apmail-streams-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id C199E11CCE
	for <apmail-streams-dev-archive@minotaur.apache.org>;
 Fri, 27 Jun 2014 12:59:39 +0000 (UTC)
Received: (qmail 10420 invoked by uid 500); 27 Jun 2014 12:59:39 -0000
Delivered-To: apmail-streams-dev-archive@streams.apache.org
Received: (qmail 10374 invoked by uid 500); 27 Jun 2014 12:59:39 -0000
Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@streams.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@streams.incubator.apache.org>
List-Post: <mailto:dev@streams.incubator.apache.org>
List-Id: <dev.streams.incubator.apache.org>
Reply-To: dev@streams.incubator.apache.org
Delivered-To: mailing list dev@streams.incubator.apache.org
Received: (qmail 10360 invoked by uid 99); 27 Jun 2014 12:59:39 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Jun 2014 12:59:39 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3)
    by apache.org (qpsmtpd/0.29) with SMTP; Fri, 27 Jun 2014 12:59:40 +0000
Received: (qmail 10251 invoked by uid 99); 27 Jun 2014 12:59:15 -0000
Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org)
 (140.211.11.114)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Jun 2014 12:59:15 +0000
Received: by tyr.zones.apache.org (Postfix, from userid 65534)
	id DB23798DA22; Fri, 27 Jun 2014 12:59:14 +0000 (UTC)
From: sieverssj <git@git.apache.org>
To: dev@streams.incubator.apache.org
Reply-To: dev@streams.incubator.apache.org
References: <git-pr-45-incubator-streams@git.apache.org>
In-Reply-To: <git-pr-45-incubator-streams@git.apache.org>
Subject: [GitHub] incubator-streams pull request: Fixed the
 ElasticSearchPersistWrit...
Content-Type: text/plain
Message-Id: <20140627125914.DB23798DA22@tyr.zones.apache.org>
Date: Fri, 27 Jun 2014 12:59:14 +0000 (UTC)
X-Virus-Checked: Checked by ClamAV on apache.org

Github user sieverssj commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/45#discussion_r14291158
  
    --- Diff: streams-contrib/streams-persist-elasticsearch/src/main/java/org/apache/streams/elasticsearch/ElasticsearchPersistWriter.java ---
    @@ -533,22 +424,8 @@ public void createIndexIfMissing(String indexName) {
             }
         }
     
    -    public void add(String indexName, String type, Map<String, Object> toImport) {
    -        for (String id : toImport.keySet())
    -            add(indexName, type, id, (String) toImport.get(id));
    -    }
    -
    -    private void checkThenAddBatch(String index, String type, Map<String, String> workingBatch) {
    -        Set<String> invalidIDs = checkIds(workingBatch.keySet(), index, type);
    -
    -        for (String toAddId : workingBatch.keySet())
    -            if (!invalidIDs.contains(toAddId))
    -                add(index, type, toAddId, workingBatch.get(toAddId));
    -
    -        LOGGER.info("Adding Batch: {} -> {}", workingBatch.size(), invalidIDs.size());
    -    }
    -
    -
    +    /**
    --- End diff --
    
    If this is no longer used it should be removed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---