streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STREAMS-113) Allow for conversion between User and Activity
Date Tue, 24 Jun 2014 15:46:25 GMT

    [ https://issues.apache.org/jira/browse/STREAMS-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14042264#comment-14042264
] 

ASF GitHub Bot commented on STREAMS-113:
----------------------------------------

Github user mfranklin commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/42#discussion_r14136531
  
    --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/processor/TwitterTypeConverter.java
---
    @@ -158,7 +176,7 @@ public boolean isValidJSON(final String json) {
                     node = (ObjectNode)mapper.valueToTree(item);
     
                     // since data is coming from outside provider, we don't know what type
the events are
    -                Class inClass = TwitterEventClassifier.detectClass((String)item);
    +                Class inClass = TwitterEventClassifier.detectClass(item.toString());
    --- End diff --
    
    would be better to use mapper.writeValueAsString


> Allow for conversion between User and Activity
> ----------------------------------------------
>
>                 Key: STREAMS-113
>                 URL: https://issues.apache.org/jira/browse/STREAMS-113
>             Project: Streams
>          Issue Type: Task
>            Reporter: Robert Douglas
>
> It could prove useful to be able to convert a Twitter User to an Activity object. The
majority of this Activity object would be empty, but all relevant fields in the actor attribute
would be filled in.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message