streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STREAMS-107) TwitterProfileProcessor should break out method to create StreamsDatum with custom ID
Date Thu, 05 Jun 2014 16:10:04 GMT

    [ https://issues.apache.org/jira/browse/STREAMS-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018903#comment-14018903
] 

ASF GitHub Bot commented on STREAMS-107:
----------------------------------------

GitHub user robdouglas opened a pull request:

    https://github.com/apache/incubator-streams/pull/37

    Streams 107

    STREAMS-107 | Added in license header and broke out method to create a new StreamsDatum
object. This way, any classes that extend TwitterProfileProcessor can override how their individual
StreamsDatum objects get created (with a different ID, for example)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robdouglas/incubator-streams STREAMS-107

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-streams/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #37
    
----
commit 93914c596bee6202608b1c5e610e02e97ba90ecf
Author: Robert Douglas <rdouglas@w2odigital.com>
Date:   2014-05-29T19:38:27Z

    Merge pull request #2 from apache/master
    
    Apache merge

commit 829f8059fca65820bb3c28d677ca186531bf73b9
Author: Robert Douglas <rdouglas@w2odigital.com>
Date:   2014-06-05T15:49:41Z

    Merge pull request #3 from apache/master
    
    Merge

commit ae740c8d31f11fbe807a8fb1dcfc41b2646390fe
Author: Robert Douglas <rdouglas@w2odigital.com>
Date:   2014-06-05T16:08:09Z

    STREAMS-107 | Added in license header and broke out method to create a new StreamsDatum
object. This way, any classes that extend TwitterProfileProcessor can override how their individual
StreamsDatum objects get created (with a different ID, for example)

----


> TwitterProfileProcessor should break out method to create StreamsDatum with custom ID
> -------------------------------------------------------------------------------------
>
>                 Key: STREAMS-107
>                 URL: https://issues.apache.org/jira/browse/STREAMS-107
>             Project: Streams
>          Issue Type: Task
>            Reporter: Robert Douglas
>            Priority: Minor
>
> At the moment, in TwitterProfileProcessor's process method, after identifying the kind
of incoming class we manually creates a new StreamsDatum object and add that to the result
list. In order to have extensions of this class where we use different identifiers for the
resulting StreamsDatum objects, we would need to break the creation of the StreamsDatum object
out into a separate method where we can override it.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message