streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From smashew <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Fixed the ElasticSearchPersistWrit...
Date Fri, 27 Jun 2014 14:55:26 GMT
Github user smashew commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/45#discussion_r14296459
  
    --- Diff: streams-contrib/streams-persist-elasticsearch/src/main/java/org/apache/streams/elasticsearch/ElasticsearchPersistWriter.java
---
    @@ -533,22 +424,8 @@ public void createIndexIfMissing(String indexName) {
             }
         }
     
    -    public void add(String indexName, String type, Map<String, Object> toImport)
{
    -        for (String id : toImport.keySet())
    -            add(indexName, type, id, (String) toImport.get(id));
    -    }
    -
    -    private void checkThenAddBatch(String index, String type, Map<String, String>
workingBatch) {
    -        Set<String> invalidIDs = checkIds(workingBatch.keySet(), index, type);
    -
    -        for (String toAddId : workingBatch.keySet())
    -            if (!invalidIDs.contains(toAddId))
    -                add(index, type, toAddId, workingBatch.get(toAddId));
    -
    -        LOGGER.info("Adding Batch: {} -> {}", workingBatch.size(), invalidIDs.size());
    -    }
    -
    -
    +    /**
    --- End diff --
    
    it is, that is why it is red.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message