streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mfranklin <>
Subject [GitHub] incubator-streams pull request: STREAMS-113 | Added ability to con...
Date Tue, 24 Jun 2014 15:44:30 GMT
Github user mfranklin commented on a diff in the pull request:
    --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/processor/
    @@ -158,7 +176,7 @@ public boolean isValidJSON(final String json) {
                     node = (ObjectNode)mapper.valueToTree(item);
                     // since data is coming from outside provider, we don't know what type
the events are
    -                Class inClass = TwitterEventClassifier.detectClass((String)item);
    +                Class inClass = TwitterEventClassifier.detectClass(item.toString());
    --- End diff --
    would be better to use mapper.writeValueAsString

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message