Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@streams.incubator.apache.org
Date: Mon, 12 May 2014 17:58:19 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@streams.incubator.apache.org
Message-ID: <JIRA.12712965.1399500664420.330925.1399917499726@arcas>
In-Reply-To: <JIRA.12712965.1399500664420@arcas>
References: <JIRA.12712965.1399500664420@arcas>
Subject: [jira] [Commented] (STREAMS-75) Refactor
 contrib/streams-processor-urls
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/STREAMS-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995331#comment-13995331 ] 

ASF GitHub Bot commented on STREAMS-75:
---------------------------------------

Github user smashew commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/13#discussion_r12543630
  
    --- Diff: streams-contrib/streams-processor-urls/src/main/java/org/apache/streams/urls/LinkResolver.java ---
    @@ -14,31 +14,43 @@
     import java.net.URLDecoder;
     import java.util.*;
     
    -/**
    - * References:
    - * Some helpful references to help
    - * Purpose              URL
    - * -------------        ----------------------------------------------------------------
    - * [Status Codes]       http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html
    - * [Test Cases]         http://greenbytes.de/tech/tc/httpredirects/
    - * [t.co behavior]      https://dev.twitter.com/docs/tco-redirection-behavior
    - */
    -
    -public class LinkResolver implements Serializable
    -{
    +public class LinkResolver implements Serializable {
    +
    +    /**
    --- End diff --
    
    I don't know that it is JavaDoc worthy. More helpful to the developer of the class and it's internals. It helps to explain the nuances of redirects as it relates to different domains. Something that the caller shouldn't need to be aware of from a 'doc' perspective.


> Refactor contrib/streams-processor-urls
> ---------------------------------------
>
>                 Key: STREAMS-75
>                 URL: https://issues.apache.org/jira/browse/STREAMS-75
>             Project: Streams
>          Issue Type: Bug
>            Reporter: Matthew Hager
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> refactor this class for readability and usability. 


--
This message was sent by Atlassian JIRA
(v6.2#6252)