Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@streams.incubator.apache.org
From: mfranklin <git@git.apache.org>
To: dev@streams.incubator.apache.org
Reply-To: dev@streams.incubator.apache.org
References: <git-pr-17-incubator-streams@git.apache.org>
In-Reply-To: <git-pr-17-incubator-streams@git.apache.org>
Subject: [GitHub] incubator-streams pull request: Streams 86
Content-Type: text/plain
Message-Id: <20140519194616.9DBF6987FEE@tyr.zones.apache.org>
Date: Mon, 19 May 2014 19:46:16 +0000 (UTC)

Github user mfranklin commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/17#discussion_r12812492
  
    --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java ---
    @@ -246,9 +281,15 @@ public void prepare(Object o) {
             includeEntitiesEnabled = Optional.fromNullable(new Boolean(Boolean.parseBoolean(config.getIncludeEntities()))).or(true);
     
             client = getTwitterClient();
    +
    +        try {
    +            lock.writeLock().lock();
    +            providerQueue = constructQueue();
    +        } finally {
    +            lock.writeLock().unlock();
    --- End diff --
    
    Agreed on finality.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---