Return-Path: 
 <dev-return-901-apmail-streams-dev-archive=streams.apache.org@streams.incubator.apache.org>
X-Original-To: apmail-streams-dev-archive@minotaur.apache.org
Delivered-To: apmail-streams-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 426C41152D
	for <apmail-streams-dev-archive@minotaur.apache.org>;
 Mon, 19 May 2014 19:31:06 +0000 (UTC)
Received: (qmail 62290 invoked by uid 500); 19 May 2014 19:31:06 -0000
Delivered-To: apmail-streams-dev-archive@streams.apache.org
Received: (qmail 62249 invoked by uid 500); 19 May 2014 19:31:06 -0000
Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@streams.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@streams.incubator.apache.org>
List-Post: <mailto:dev@streams.incubator.apache.org>
List-Id: <dev.streams.incubator.apache.org>
Reply-To: dev@streams.incubator.apache.org
Delivered-To: mailing list dev@streams.incubator.apache.org
Received: (qmail 62239 invoked by uid 99); 19 May 2014 19:31:06 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 May 2014 19:31:06 +0000
X-ASF-Spam-Status: No, hits=-2000.7 required=5.0
	tests=ALL_TRUSTED,RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3)
    by apache.org (qpsmtpd/0.29) with SMTP; Mon, 19 May 2014 19:31:05 +0000
Received: (qmail 62133 invoked by uid 99); 19 May 2014 19:30:44 -0000
Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org)
 (140.211.11.114)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 May 2014 19:30:44 +0000
Received: by tyr.zones.apache.org (Postfix, from userid 65534)
	id B206F987FC6; Mon, 19 May 2014 19:30:44 +0000 (UTC)
From: smashew <git@git.apache.org>
To: dev@streams.incubator.apache.org
Reply-To: dev@streams.incubator.apache.org
References: <git-pr-17-incubator-streams@git.apache.org>
In-Reply-To: <git-pr-17-incubator-streams@git.apache.org>
Subject: [GitHub] incubator-streams pull request: Streams 86
Content-Type: text/plain
Message-Id: <20140519193044.B206F987FC6@tyr.zones.apache.org>
Date: Mon, 19 May 2014 19:30:44 +0000 (UTC)
X-Virus-Checked: Checked by ClamAV on apache.org

Github user smashew commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/17#discussion_r12811784
  
    --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java ---
    @@ -54,12 +72,14 @@ public void setConfig(TwitterStreamConfiguration config) {
             this.config = config;
         }
     
    -    protected final Queue<StreamsDatum> providerQueue = Queues.synchronizedQueue(new ArrayBlockingQueue<StreamsDatum>(5000));
    +    protected volatile Queue<StreamsDatum> providerQueue;
     
         protected int idsCount;
         protected Twitter client;
    --- End diff --
    
    This should be a local variable to CaptureTimeline for flexibility.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---