Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@streams.incubator.apache.org
From: mfranklin <git@git.apache.org>
To: dev@streams.incubator.apache.org
Reply-To: dev@streams.incubator.apache.org
References: <git-pr-13-incubator-streams@git.apache.org>
In-Reply-To: <git-pr-13-incubator-streams@git.apache.org>
Subject: [GitHub] incubator-streams pull request: Changes necessary to satisfy
 JIRA ...
Content-Type: text/plain
Message-Id: <20140512175028.B66AB1602E@tyr.zones.apache.org>
Date: Mon, 12 May 2014 17:50:28 +0000 (UTC)

Github user mfranklin commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/13#discussion_r12543282
  
    --- Diff: streams-contrib/streams-processor-urls/src/main/java/org/apache/streams/urls/LinkResolver.java ---
    @@ -14,31 +14,43 @@
     import java.net.URLDecoder;
     import java.util.*;
     
    -/**
    - * References:
    - * Some helpful references to help
    - * Purpose              URL
    - * -------------        ----------------------------------------------------------------
    - * [Status Codes]       http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html
    - * [Test Cases]         http://greenbytes.de/tech/tc/httpredirects/
    - * [t.co behavior]      https://dev.twitter.com/docs/tco-redirection-behavior
    - */
    -
    -public class LinkResolver implements Serializable
    -{
    +public class LinkResolver implements Serializable {
    +
    +    /**
    --- End diff --
    
    Wouldn't this javadoc go above the interface declaration?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---