Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@streams.incubator.apache.org
From: smashew <git@git.apache.org>
To: dev@streams.incubator.apache.org
Reply-To: dev@streams.incubator.apache.org
References: <git-pr-8-incubator-streams@git.apache.org>
In-Reply-To: <git-pr-8-incubator-streams@git.apache.org>
Subject: [GitHub] incubator-streams pull request: Twitter Modificaitons
Content-Type: text/plain
Message-Id: <20140506004300.EA64392051A@tyr.zones.apache.org>
Date: Tue,  6 May 2014 00:43:00 +0000 (UTC)

Github user smashew commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/8#discussion_r12307454
  
    --- Diff: streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StatusCounterMonitorRunnable.java ---
    @@ -0,0 +1,6 @@
    +package org.apache.streams.local.tasks;
    +
    +public interface StatusCounterMonitorRunnable extends Runnable {
    --- End diff --
    
    I think that it does, right now, the monitor thread doesn't shutdown properly because of the way that it is being tracked. This behavior is largely invisible because it would have to be run in debug mode for it to be immediately apparent. IMHO, anything that can be run as a thread against in LocalStreamsBuilder that has a while(this.isRunning) { } loop, should have an interface that allows them to be terminated generically. Otherwise, it is possible to miss the destruction of it. With that style of loop, even through references are terminated, it will continue to run unless the flag is set and it can escape the function.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---