streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STREAMS-93) Add generic extensions from multiple providers
Date Tue, 27 May 2014 16:03:02 GMT

    [ https://issues.apache.org/jira/browse/STREAMS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14009837#comment-14009837
] 

ASF GitHub Bot commented on STREAMS-93:
---------------------------------------

Github user mfranklin commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/25#discussion_r13085712
  
    --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/serializer/util/TwitterActivityUtil.java
---
    @@ -174,10 +176,28 @@ public static Actor buildActor(Tweet tweet) {
                             .or(Optional.of(user.getId().toString()))
                             .orNull()
             ));
    -        actor.setDisplayName(user.getScreenName());
    +
    +        actor.setDisplayName(user.getName());
    +        actor.setAdditionalProperty("handle", user.getScreenName());
    +        actor.setSummary(user.getDescription());
    +
             if (user.getUrl()!=null){
                 actor.setUrl(user.getUrl());
             }
    +
    +        Map<String, Object> extensions = new HashMap<String, Object>();
    +        extensions.put("location", user.getLocation());
    +        extensions.put("posts", user.getStatusesCount());
    +        extensions.put("favorites", user.getFavouritesCount());
    +        extensions.put("followers", user.getFollowersCount());
    +
    +        Map<String, Object> image = new HashMap<String, Object>();
    +        image.put("url", user.getProfileImageUrlHttps());
    --- End diff --
    
    I believe the profile image should be a media link in the image property of the actor
object per
    http://activitystrea.ms/specs/json/1.0/#object


> Add generic extensions from multiple providers
> ----------------------------------------------
>
>                 Key: STREAMS-93
>                 URL: https://issues.apache.org/jira/browse/STREAMS-93
>             Project: Streams
>          Issue Type: Task
>            Reporter: Robert Douglas
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> At the moment, if we want to grab out things like "hashtags" or "Number of Likes" from
an activity, we have to delve into that provider's extension. So, for example, "extensions.twitter.entities.hashtags.text".
There are certain attributes that are consistent across multiple providers and could benefit
from being placed at the top level of the "extensions" attribute. 
> These would include things like "hashtags", "rebroadcasts", "likes", "user_mentions",
and "urls"



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message