streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STREAMS-93) Add generic extensions from multiple providers
Date Thu, 22 May 2014 17:13:02 GMT

    [ https://issues.apache.org/jira/browse/STREAMS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14006143#comment-14006143
] 

ASF GitHub Bot commented on STREAMS-93:
---------------------------------------

Github user mfranklin commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/25#discussion_r12961535
  
    --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/serializer/TwitterJsonTweetActivitySerializer.java
---
    @@ -78,35 +80,71 @@ public Activity deserialize(String serialized) throws ActivitySerializerExceptio
             activity.setProvider(getProvider());
             activity.setTitle("");
             activity.setContent(tweet.getText());
    -        activity.setUrl("http://twitter.com/" + tweet.getIdStr());
    +        activity.setUrl("http://twitter.com/" + tweet.getUser().getIdStr() + "/status/"
+ tweet.getIdStr());
             activity.setLinks(getLinks(tweet));
     
             addTwitterExtension(activity, mapper.convertValue(tweet, ObjectNode.class));
             addLocationExtension(activity, tweet);
    +        addTwitterExtensions(activity, tweet);
    +
             return activity;
         }
     
    +    public static void addTwitterExtensions(Activity activity, Tweet tweet) {
    --- End diff --
    
    This seems like it should be a utility function rather than duplicated logic with the
class above.


> Add generic extensions from multiple providers
> ----------------------------------------------
>
>                 Key: STREAMS-93
>                 URL: https://issues.apache.org/jira/browse/STREAMS-93
>             Project: Streams
>          Issue Type: Task
>            Reporter: Robert Douglas
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> At the moment, if we want to grab out things like "hashtags" or "Number of Likes" from
an activity, we have to delve into that provider's extension. So, for example, "extensions.twitter.entities.hashtags.text".
There are certain attributes that are consistent across multiple providers and could benefit
from being placed at the top level of the "extensions" attribute. 
> These would include things like "hashtags", "rebroadcasts", "likes", "user_mentions",
and "urls"



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message