streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STREAMS-80) StreamsProcressorTask and StreamsPersistWriterTask are BROKEN
Date Sat, 17 May 2014 05:01:17 GMT

    [ https://issues.apache.org/jira/browse/STREAMS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000669#comment-14000669
] 

ASF GitHub Bot commented on STREAMS-80:
---------------------------------------

Github user smashew commented on the pull request:

    https://github.com/apache/incubator-streams/pull/15#issuecomment-43397816
  
    FYI... PR 16
    https://github.com/apache/incubator-streams/pull/16
    
    Additionally satisfies this request and many others with a large suite of tests to ensure
orphaned data does not occur. I don't know how, if at all, these two PRs would merge together.
:(


> StreamsProcressorTask and StreamsPersistWriterTask are BROKEN
> -------------------------------------------------------------
>
>                 Key: STREAMS-80
>                 URL: https://issues.apache.org/jira/browse/STREAMS-80
>             Project: Streams
>          Issue Type: Bug
>            Reporter: Ryan Ebanks
>            Priority: Critical
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> A recent commit seems to have introduced this.  Its a simple fix, but the while statement
on line 70 of StreamsProviderTask should read
> while(this.keepRunning.get() || datum != null) {
> And line 75 in StreamsPersist writer task should read
> while(this.keepRunning.get() || datum != null) {
> Both lines are missing the datum != null statement.  This causes tasks to be shutdown
before data is processed and data is orphaned in the stream.  In the worst case only the provider
runs.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message