streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STREAMS-80) StreamsProcressorTask and StreamsPersistWriterTask are BROKEN
Date Wed, 21 May 2014 15:08:38 GMT

    [ https://issues.apache.org/jira/browse/STREAMS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004745#comment-14004745
] 

ASF GitHub Bot commented on STREAMS-80:
---------------------------------------

Github user rbnks commented on the pull request:

    https://github.com/apache/incubator-streams/pull/15#issuecomment-43766976
  
    @mfranklin  So I can see how maybe we want to change the name of keepRunning, or we might
want to have a shut off now method in the future.  But currently we only have one way to shut
down the queue.  And checking if 'datum != null' will flush all of the data out of the queue
before it shuts.  And since local mode shuts down each task in upstream to downstream order,
we can know we will flush all of the data.


> StreamsProcressorTask and StreamsPersistWriterTask are BROKEN
> -------------------------------------------------------------
>
>                 Key: STREAMS-80
>                 URL: https://issues.apache.org/jira/browse/STREAMS-80
>             Project: Streams
>          Issue Type: Bug
>            Reporter: Ryan Ebanks
>            Priority: Critical
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> A recent commit seems to have introduced this.  Its a simple fix, but the while statement
on line 70 of StreamsProviderTask should read
> while(this.keepRunning.get() || datum != null) {
> And line 75 in StreamsPersist writer task should read
> while(this.keepRunning.get() || datum != null) {
> Both lines are missing the datum != null statement.  This causes tasks to be shutdown
before data is processed and data is orphaned in the stream.  In the worst case only the provider
runs.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message