streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STREAMS-75) Refactor contrib/streams-processor-urls
Date Mon, 12 May 2014 18:08:16 GMT

    [ https://issues.apache.org/jira/browse/STREAMS-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995356#comment-13995356
] 

ASF GitHub Bot commented on STREAMS-75:
---------------------------------------

Github user mfranklin commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/13#discussion_r12544330
  
    --- Diff: streams-contrib/streams-processor-urls/src/main/java/org/apache/streams/urls/DomainSensitivity.java
---
    @@ -0,0 +1,122 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.streams.urls;
    +
    +import java.util.*;
    +import java.util.concurrent.ConcurrentHashMap;
    +import java.util.concurrent.ConcurrentMap;
    +
    +/**
    + * This is a static utility helper class to obey domain sensitivity. It cannot be
    + * instantiated and can only be referenced through the static accessor functions
    + *
    + */
    +public abstract class DomainSensitivity {
    --- End diff --
    
    If you remove the abstract, I think we are all set with this one.


> Refactor contrib/streams-processor-urls
> ---------------------------------------
>
>                 Key: STREAMS-75
>                 URL: https://issues.apache.org/jira/browse/STREAMS-75
>             Project: Streams
>          Issue Type: Bug
>            Reporter: Matthew Hager
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> refactor this class for readability and usability. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message