streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STREAMS-75) Refactor contrib/streams-processor-urls
Date Mon, 12 May 2014 17:52:15 GMT

    [ https://issues.apache.org/jira/browse/STREAMS-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995318#comment-13995318
] 

ASF GitHub Bot commented on STREAMS-75:
---------------------------------------

Github user mfranklin commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/13#discussion_r12543282
  
    --- Diff: streams-contrib/streams-processor-urls/src/main/java/org/apache/streams/urls/LinkResolver.java
---
    @@ -14,31 +14,43 @@
     import java.net.URLDecoder;
     import java.util.*;
     
    -/**
    - * References:
    - * Some helpful references to help
    - * Purpose              URL
    - * -------------        ----------------------------------------------------------------
    - * [Status Codes]       http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html
    - * [Test Cases]         http://greenbytes.de/tech/tc/httpredirects/
    - * [t.co behavior]      https://dev.twitter.com/docs/tco-redirection-behavior
    - */
    -
    -public class LinkResolver implements Serializable
    -{
    +public class LinkResolver implements Serializable {
    +
    +    /**
    --- End diff --
    
    Wouldn't this javadoc go above the interface declaration?


> Refactor contrib/streams-processor-urls
> ---------------------------------------
>
>                 Key: STREAMS-75
>                 URL: https://issues.apache.org/jira/browse/STREAMS-75
>             Project: Streams
>          Issue Type: Bug
>            Reporter: Matthew Hager
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> refactor this class for readability and usability. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message