streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steve Blackmon <sblack...@apache.org>
Subject Re: [GitHub] incubator-streams pull request: Streams 41
Date Wed, 21 May 2014 19:08:47 GMT
I've also seen class version issues running code built with JDK7 in JDK6.

Has anyone seen good patterns for building releases/snapshots with
both JDK versions?  Could we use profiles to do this?

While I support switching everything to java 7 in theory, I suspect
doing so would make it impossible to run much of the project on java 6
rather than just specific modules with upstream dependencies built
with java 7.

Steve Blackmon
sblackmon@apache.org


On Tue, May 20, 2014 at 4:58 PM, rbnks <git@git.apache.org> wrote:
> GitHub user rbnks opened a pull request:
>
>     https://github.com/apache/incubator-streams/pull/23
>
>     Streams 41
>
>     Fixed datasift stream provider and created tests.
>     DISCLAIMER:
>     The datasift api requires the use of java 7.  Although this will compile with java
6 it will not run.  I @ignored all of the tests so they wouldn't break the build.  I don't
know how we want to handle this, but I vote we move to switching the entire project to use
java 7.  I have confirmed that all classes compile and all tests pass with java 7.
>
> You can merge this pull request into a Git repository by running:
>
>     $ git pull https://github.com/rbnks/incubator-streams STREAMS-41
>
> Alternatively you can review and apply these changes as the patch at:
>
>     https://github.com/apache/incubator-streams/pull/23.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
>     This closes #23
>
> ----
> commit f1b46208c680309be7f021bee29bee08a28730c1
> Author: rebanks <rebanks@w2odigital.com>
> Date:   2014-05-20T21:18:34Z
>
>     Datasift Fixes and tests
>
> commit 7b1fb676039cbf960ee47aa402d496fbd5892efb
> Author: rebanks <rebanks@w2odigital.com>
> Date:   2014-05-20T21:44:29Z
>
>     Added more javadoc comments
>
> commit 23fd12dade54c90e55b1667520906eeb8652da78
> Author: rebanks <rebanks@w2odigital.com>
> Date:   2014-05-20T21:48:21Z
>
>     Added license headers
>
> commit e58d7054b86aee9eae75f019cbaaf9288a2402e0
> Author: rebanks <rebanks@w2odigital.com>
> Date:   2014-05-20T21:53:24Z
>
>     Ignored tests
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---

Mime
View raw message