streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Hager [W2O Digital]" <mha...@w2odigital.com>
Subject Re: [GitHub] incubator-streams pull request: Twitter Modificaitons
Date Tue, 06 May 2014 13:31:23 GMT
I actually thought about that name myself, because of the name of the derived classes I had
a large internal debate. I am amicable to any name anyone could want.

Sent from my iPhone

> On May 6, 2014, at 8:22 AM, "mfranklin" <git@git.apache.org> wrote:
> 
> Github user mfranklin commented on a diff in the pull request:
> 
>    http://cp.mcafee.com/d/5fHCN8edEICzAQsIL9LIK6XCQQmhPMWWrMUSCyMy-yCOyedFEIzDxRQTDzqqb339EVd7a8VASGjQzYgkojGx8zauDYKrc9RgAhBfj-ndLnjZVNB_HYyyyqen6uLsKCy-qeujLt5ZPBHFShhlKqenel3PWApmU6CQjq9K_9TLuZXTLsTsSjDdqymohBcCSgVvdmSNfYB2Pp3pRynFefWHj5CPPYu0N2lbdQFaI1maararapEVudEupbN-rso5TAnyWFfifNec9RgAhBfj-n1l9N_lqta5CO6PH7JmSNf-00CSkT4PpFr2kFxtIwqnjh1a5CO6PH4LisvRmxEwmrffd44v5C_Fd8Qg0ANas_yq81KG4DpmSkWMErsjdCz8f
> 
>    --- Diff: streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StatusCounterMonitorRunnable.java
---
>    @@ -0,0 +1,6 @@
>    +package org.apache.streams.local.tasks;
>    +
>    +public interface StatusCounterMonitorRunnable extends Runnable {
>    --- End diff --
> 
>    Completely agree on the use of the interface.  I was just wondering why it is StatusCounterMonitorRunnable
when its methods are shutdown and isRunning.  It would make sense to me to call it StoppableRunnable
or something like that; but, I may be misunderstanding the use case and the Java Doc on the
interface doesn't clarify it for me.
> 
> 
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---

Mime
View raw message