streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rbnks <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Streams 41
Date Tue, 27 May 2014 16:43:03 GMT
Github user rbnks commented on the pull request:

    https://github.com/apache/incubator-streams/pull/23#issuecomment-44301942
  
    Added the build profile so tests only build/run when java7 is being used.  I did not use
the Component utils for offerUntilSuccess because it includes an unnecessary lock.  It locks
on the ComponentUtils.class, so it doesn't lock the queue, it just locks those helper methods.
 The class uses a ConcurrentQueue, so it handles locking on its own and there is no need to
lock other threads out of using ComponentUtils during this offer(...).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message