streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robdouglas <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: STREAMS-93 | Updated the Hashtag P...
Date Thu, 22 May 2014 17:17:47 GMT
Github user robdouglas commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/25#discussion_r12961833
  
    --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/serializer/TwitterJsonTweetActivitySerializer.java
---
    @@ -78,35 +80,71 @@ public Activity deserialize(String serialized) throws ActivitySerializerExceptio
             activity.setProvider(getProvider());
             activity.setTitle("");
             activity.setContent(tweet.getText());
    -        activity.setUrl("http://twitter.com/" + tweet.getIdStr());
    +        activity.setUrl("http://twitter.com/" + tweet.getUser().getIdStr() + "/status/"
+ tweet.getIdStr());
             activity.setLinks(getLinks(tweet));
     
             addTwitterExtension(activity, mapper.convertValue(tweet, ObjectNode.class));
             addLocationExtension(activity, tweet);
    +        addTwitterExtensions(activity, tweet);
    +
             return activity;
         }
     
    +    public static void addTwitterExtensions(Activity activity, Tweet tweet) {
    --- End diff --
    
    Valid point, pushed change


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message