streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mfranklin <>
Subject [GitHub] incubator-streams pull request: STREAMS-93 | Updated the Hashtag P...
Date Thu, 22 May 2014 17:11:10 GMT
Github user mfranklin commented on a diff in the pull request:
    --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/serializer/
    @@ -78,35 +80,71 @@ public Activity deserialize(String serialized) throws ActivitySerializerExceptio
    -        activity.setUrl("" + tweet.getIdStr());
    +        activity.setUrl("" + tweet.getUser().getIdStr() + "/status/"
+ tweet.getIdStr());
             addTwitterExtension(activity, mapper.convertValue(tweet, ObjectNode.class));
             addLocationExtension(activity, tweet);
    +        addTwitterExtensions(activity, tweet);
             return activity;
    +    public static void addTwitterExtensions(Activity activity, Tweet tweet) {
    --- End diff --
    This seems like it should be a utility function rather than duplicated logic with the
class above.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message