streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From smashew <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: STREAMS-87 | We now try to collect...
Date Mon, 19 May 2014 21:34:10 GMT
Github user smashew commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/19#discussion_r12817666
  
    --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java
---
    @@ -116,10 +116,8 @@ protected void captureTimeline(long currentId) {
                 int keepTrying = 0;
     
                 // keep trying to load, give it 5 attempts.
    -            //while (keepTrying < 10)
    -            while (keepTrying < 1)
    +            while (keepTrying < 5)
    --- End diff --
    
    5 is a magic number. It is the typical number of times I had to ask a girl if she would
go on a date with me. If she said 'no' 5 times, that is when I retreated. Empirical or not,
it is a good rule of thumb.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message